Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21107 Update ICU4C minimum standard version from C++11 to C++17 #2737

Merged
merged 2 commits into from
Dec 14, 2023
Merged

ICU-21107 Update ICU4C minimum standard version from C++11 to C++17 #2737

merged 2 commits into from
Dec 14, 2023

Conversation

roubert
Copy link
Member

@roubert roubert commented Dec 11, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-21107
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

ALLOW_MANY_COMMITS=true

@roubert roubert changed the title 21107 ICU-21107 Update ICU4C minimum standard version from C++11 to C++17 Dec 11, 2023
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/depstest/dependencies.txt is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@roubert roubert requested review from markusicu and jefgen December 11, 2023 20:11
@markusicu

This comment was marked as resolved.

Sign in to view
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/unicode/platform.h is now changed in the branch
  • icu4c/source/Doxyfile.in is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@roubert

This comment was marked as resolved.

Sign in to view
@markusicu
Copy link
Member

lgtm tnx -- but we might wait until the meeting on Thursday just so that everyone is on the same page

@roubert
Copy link
Member Author

roubert commented Dec 13, 2023

lgtm tnx -- but we might wait until the meeting on Thursday just so that everyone is on the same page

Please merge whenever you find that the timing is right.

markusicu
markusicu approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

@markusicu markusicu merged commit 1bc059e into unicode-org:main Dec 14, 2023
98 checks passed
@roubert roubert deleted the 21107 branch December 14, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@jefgen jefgen Awaiting requested review from jefgen

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roubert @markusicu